Implement walking of Attribute super types to check AttributeUsage #10834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Jan 4, 2021
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
I dig it. Looks like a lame macos failure again
Member
Author
|
I would like someone smarter than me to think through the |
Contributor
|
I might be wrong about this but I believe Inherited is entirely a runtime concern, reflection (and maybe the clr type system) takes it into account when queried. |
KevinRansom
approved these changes
Jan 15, 2021
Contributor
|
Thanks for this looks Good, Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9256 by checking all super types of an attribute for AllowMultiple.
This is done by creating a sequence of types that need to be checked for AllowMultiple, and walking that sequence until one of them returns a concrete value for AllowMultiple. This is a pretty simplistic strategy, and I'm not sure how it interacts with the
Inheritedproperty of AttributeUsage. I've added a test case as well to prove that this works as expected, though I could certainly use some additional test cases to ensure this works across all cases. If there is more logic necessary to takeInheritedinto consideration, it should be pretty easy to stop the type-hierarchy traversal just by returning aSomevalue at that level, which would satisfy thetryPick.