[Tooling] Prevent impl files with backing sig files from invalidating the build #10650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
changed the title
cartermp
approved these changes
Dec 9, 2020
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Oh this is excellent. Love how simply the change is too.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
… the build (dotnet#10650) * Prevent impl files with backing sig files from invalidating the build * Check states on invalidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements this: #10210
The refactor of incremental build has payed off. In the end, the solution to this required only a few changes.
The perf impact at the moment is completely night and day. Modifying then saving an impl file that has a backing sig file - is almost zero cost when VS/Roslyn tries to analyze other files that depend on it.