Skip to content

Conversation

@OmarTawfik
Copy link
Contributor

This PR Includes

  • Moving localization/signing process to Microbuild.
  • Stamping all binaries/executables produced by version number and build date.
  • Separating project and item templates into separate projects.
  • adding microbuild-everything.proj that builds all binaries on all platforms supported.
  • Removing support for 9055 OSS version (depending on the new build stamps now).

/cc @Microsoft/fsharp-compiler

@ctaggart
Copy link
Contributor

What is MicroBuild? Is it open source? Is it the new MSBuild? I noticed this uses MicroBuild.Core 0.2.0. I see that it is uploaded both places:

https://dotnet.myget.org/gallery/dotnet-buildtools
https://www.nuget.org/packages/MicroBuild.Core/

@KevinRansom
Copy link
Contributor

Looks great ... ship it :-)

@KevinRansom
Copy link
Contributor

@ctaggart Microbuild is the thing that gets us out of the big VS build process internally. It is a step towards removing all of that internal machinery we now have to worry about.

For example after this change our internal product build will not have a separate set of project files. Which was always embarrassing but unavoidable.

@OmarTawfik OmarTawfik merged commit 132f076 into dotnet:master Mar 31, 2016
@OmarTawfik OmarTawfik deleted the microbuild-v2 branch March 31, 2016 21:23
msbuild vsintegration/fsharp-vsintegration-item-templates-build.proj
msbuild vsintegration/fsharp-vsintegration-deployment-build.proj
msbuild vsintegration\fsharp-vsintegration-unittests-build.proj
msbuild tests/fsharp/FSharp.Tests.fsproj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a mix of forward and backslashes here

@dsyme
Copy link
Contributor

dsyme commented Apr 4, 2016

@otawfik-ms After this commit incremental builds seem to be broken?

On master, when I do build all, all projects now get recompiled, right from proto. I suspect it's because of the generation of the AssemblyFileVersion file:

        Generating AssemblyFileVersion file: C:\Users\dsyme\AppData\Local\Temp
        \tmp8911.tmp.fs

It's really important to fix this to enable contributors to be productive in their build+tests

<FilesToLocalize Include="$(OutDir)$(AssemblyName).dll">
<TranslationFile>$(FSharpSourcesRoot)\..\loc\lcl\{Lang}\$(AssemblyName).dll.lcl</TranslationFile>
<LciCommentFile>$(FSharpSourcesRoot)\..\loc\lci\$(AssemblyName).dll.lci</LciCommentFile>
<HasLceComments>false</HasLceComments>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: indentation looks off here.

@OmarTawfik
Copy link
Contributor Author

@dsyme I believe the failures are related to the recent coreclr changes, not microbuild, which is being fixed now in a separate location.

OmarTawfik pushed a commit that referenced this pull request Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants