Skip to content

Able to remap DecisionTreeTest.Error #10187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2020
Merged

Able to remap DecisionTreeTest.Error #10187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3787079
Able to remap DecisionTreeTest.Error
TIHan Sep 25, 2020
77fd108
minor change to construct Error
TIHan Sep 25, 2020
f9cfc0b
Moved RegressionTests to ComponentTests
TIHan Sep 25, 2020
3441733
Fixed build
TIHan Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fsharp/TypedTreeOps.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5348,7 +5348,7 @@ and remapDecisionTree g compgen tmenv x =
| DecisionTreeTest.IsInst (srcty, tgty) -> DecisionTreeTest.IsInst (remapType tmenv srcty, remapType tmenv tgty)
| DecisionTreeTest.IsNull -> DecisionTreeTest.IsNull
| DecisionTreeTest.ActivePatternCase _ -> failwith "DecisionTreeTest.ActivePatternCase should only be used during pattern match compilation"
| DecisionTreeTest.Error _ -> failwith "DecisionTreeTest.Error should only be used during pattern match compilation"
| DecisionTreeTest.Error(m) -> DecisionTreeTest.Error(m)
TCase(test', remapDecisionTree g compgen tmenv y)) csl,
Option.map (remapDecisionTree g compgen tmenv) dflt,
m)
Expand Down
1 change: 1 addition & 0 deletions tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<Compile Include="ErrorMessages\WarnExpressionTests.fs" />
<Compile Include="ErrorMessages\WrongSyntaxInForLoop.fs" />
<Compile Include="ErrorMessages\ConfusingTypeName.fs" />
<Compile Include="Language\RegressionTests.fs" />
<Compile Include="Language\XmlComments.fs" />
<Compile Include="Language\CompilerDirectiveTests.fs" />
<Compile Include="Language\CodeQuotationTests.fs" />
Expand Down
21 changes: 21 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/Language/RegressionTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information.

namespace FSharp.Compiler.ComponentTests.Language

open Xunit
open FSharp.Test.Utilities.Compiler

module RegressionTests =

[<Fact>]
let ``No internal errors should be raised``() =
FSharp """
namespace FSharpBug

type TestItemSeq =
static member Test1 item = item
static member Test2 item = match item with Typo2 x -> x
"""
|> compile
|> withErrorCodes [39]
|> ignore