Skip to content

Conversation

@KevinRansom
Copy link
Contributor

Fixes #10144

mea culpa ... throw big sticks at me over this, I completely missed it.

@cartermp
Copy link
Contributor

LanguageFeature.OverloadsForCustomOperations should also be lifted to 50. It works great. Otherwise, this is good

@KevinRansom
Copy link
Contributor Author

@cartermp , I will submit a seperate PR for overloads for custom operators. I know it seems silly but revert and bisect for failures is easier. And I expect that will require some test updating too.

@KevinRansom KevinRansom merged commit 79c5932 into dotnet:release/dev16.8 Sep 18, 2020
@dsyme
Copy link
Contributor

dsyme commented Sep 19, 2020

All of these are still listed as preview is that right??

            LanguageFeature.FromEndSlicing, previewVersion
            LanguageFeature.OpenTypeDeclaration, previewVersion
            LanguageFeature.PackageManagement, previewVersion
            LanguageFeature.WitnessPassing, previewVersion
            LanguageFeature.InterfacesWithMultipleGenericInstantiation, previewVersion
            LanguageFeature.NameOf, previewVersion
            LanguageFeature.StringInterpolation, previewVersion

@cartermp
Copy link
Contributor

No, only in main. I have no idea why main isn't showing this though.

https://github.com/dotnet/fsharp/blob/release/dev16.8/src/fsharp/LanguageFeatures.fs#L63

@KevinRansom
Copy link
Contributor Author

Once dev16.8 branch has rtm'd we will integrate the changes back into master. We make version changes like this only in the release branches like dev16.8. Once the release branches have rtmd they are integrated back into master. It's just the process we use and it works out fine.

@KevinRansom KevinRansom deleted the defaultversion branch October 29, 2020 18:57
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* change default language version

* Update error message

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default LangVersion for .NET 5 is still F# 4.7

3 participants