Refactor the Fsc task's toolpath logic. #10126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There are some failed tests here, could you take a look? https://dev.azure.com/dnceng/public/_build/results?buildId=815659&view=ms.vss-test-web.build-test-results-tab |
Contributor
Author
|
The test's logic is flawed. It assumes that I think this test should be either removed or adapted to the correct MSBuild behavior. |
Contributor
Please adapt the test as part of the PR and we can assess |
KevinRansom
approved these changes
Oct 5, 2020
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Thanks for this change.
cartermp
approved these changes
Oct 5, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Refactor the Fsc task's toolpath logic. * Remove invalid test case Co-authored-by: KevinRansom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a
ToolPathproperty in the baseToolTaskclass.This PR removes Fsc's duplicate definition.