Inline Rename does not work on non-private symbols on dirty buffers

[vasily-kirichenko]

[vasily-kirichenko]

The bug is reproduced on dirty buffers only.

The feature uses ParseAndCheckProject here https://github.com/Microsoft/visualfsharp/blob/master/vsintegration/src/FSharp.Editor/Common/SymbolHelpers.fs#L44, which reads file contents from disk (via FileSystem class):

Project-wide diagnostics are not enabled due to the same bug, see #1856 (I've no idea why it's closed).

[cartermp]

Good catch. Hmmmm. This is definitely an important one to fix, but looking at the discussion in #1856 it seems that this may not make it into release. I'm still tagging as RTM though, since the importance of getting something like this fixed is high enough to warrant looking at it as an immediately-after-release issue.