Improve Error Reporting: Incorrect error message on 'if' expression

[isaacabraham]

Related to #1102. The following code snippet leads to a misleading error message:

type Person = { Name : string; }

let x =
    if 5 > 10 then { Name = "Isaac" }

The error is: error FS1129: The type 'unit' does not contain a field 'Name'

[isaacabraham]

cc:@forki

[forki]

What do you mean with "misleading"? I think the compiler is right.

[forki]

That said which error message would you expect here?

[isaacabraham]

I wouldn't expect the following to lead to a different error message: -

let x =
    if 5 > 10 then { Person.Name = "Isaac" }

The original snippet should IMHO give the same error (i.e. you've forgotten about the "else" branch")

[forki]

what do you mean?

[isaacabraham]

OK - I was going off Ionide, which shows the following: -

[forki]

/cc @Krzysztof-Cieslak

I assume it's not the final version in FCS/Ionide?

[isaacabraham]

I suggest we close this issue - using the "real" compiler should be sufficient to confirm that this is a non-issue, but it'd be good to know why this is occurring.

[forki]

ok maybe it's giving multiple errors, let me check that

[forki]

nope. only one error thrown. I vote to close this.

[forki]

It's still weird. Why is the other one already working?

[isaacabraham]

I can confirm that this is gone in Ionide.