Skip to content

Diagnostics 3390, 3391 reused #12417

@dsyme

Description

@dsyme

We have incorrectly reused diagnostic numbers 3390, 3391.

Warning diagnostic 3390 is off by default and this is currently intended for both its meanings tcImplicitConversionUsedForMethodArg and xmlDocBadlyFormed, and in both cases this is documented here and here.

Proposal:

  1. We re-number tcImplicitConversionUsedForMethodArg , update the documentation.
  2. We re-number tcLiteralAttributeCannotUseActivePattern just to avoid the conflict.
  3. I also propose we turn on xmlDocBadlyFormed by default but that's a separate matter.
3390,tcImplicitConversionUsedForMethodArg,"This expression uses the implicit conversion '%s' to convert type '%s' to type '%s'."
3391,tcImplicitConversionUsedForNonMethodArg,"This expression uses the implicit conversion '%s' to convert type '%s' to type '%s'. 3390,xmlDocBadlyFormed,"This XML comment is invalid: '%s'"
3391,tcLiteralAttributeCannotUseActivePattern,"A [<Literal>] declaration cannot use an active pattern for its identifier"

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions