-
Notifications
You must be signed in to change notification settings - Fork 830
Closed
Description
We have incorrectly reused diagnostic numbers 3390, 3391.
Warning diagnostic 3390 is off by default and this is currently intended for both its meanings tcImplicitConversionUsedForMethodArg and xmlDocBadlyFormed, and in both cases this is documented here and here.
Proposal:
- We re-number
tcImplicitConversionUsedForMethodArg, update the documentation. - We re-number
tcLiteralAttributeCannotUseActivePatternjust to avoid the conflict. - I also propose we turn on
xmlDocBadlyFormedby default but that's a separate matter.
3390,tcImplicitConversionUsedForMethodArg,"This expression uses the implicit conversion '%s' to convert type '%s' to type '%s'."
3391,tcImplicitConversionUsedForNonMethodArg,"This expression uses the implicit conversion '%s' to convert type '%s' to type '%s'. 3390,xmlDocBadlyFormed,"This XML comment is invalid: '%s'"
3391,tcLiteralAttributeCannotUseActivePattern,"A [<Literal>] declaration cannot use an active pattern for its identifier"