Stackoverflow when running on dotnet sdk 5.0.102

[KevinRansom]

The testcase LargeRecordDoesNotStackOverflow stack overflows

This error appears when run on the 5.0.102 dotnet frameworlk

  Passed LargeListExprDoesNotStackOverflow [282 ms]
The active test run was aborted. Reason: Test host process crashed : Stack overflow.
Repeat 11 times:
--------------------------------
   at Internal.Utilities.Collections.Tagged.MapTreeModule.add[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.Collections.Generic.IComparer`1<System.__Canon>, System.__Canon, System.__Canon, Internal.Utilities.Collections.Tagged.MapTree`2<System.__Canon,System.__Canon>)
--------------------------------
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis.logUse(Val, Microsoft.FSharp.Collections.FSharpList`1<accessor>, Microsoft.FSharp.Collections.FSharpList`1<TType>, Microsoft.FSharp.Collections.FSharpList`1<Expr>, Results)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis+recognise@260-1.Invoke(Results, Val)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at Microsoft.FSharp.Collections.ListModule.Fold[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](Microsoft.FSharp.Core.FSharpFunc`2<System.__Canon,Microsoft.FSharp.Core.FSharpFunc`2<System.__Canon,System.__Canon>>, System.__Canon, Microsoft.FSharp.Collections.FSharpList`1<System.__Canon>)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].dtreeF(System.__Canon, DecisionTree)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprNoInterceptF(System.__Canon, Expr)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprNoInterceptF(System.__Canon, Expr)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis.foldUnderLambda[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<System.__Canon,Results>>, Results, System.__Canon)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis+targetIntercept@292.Invoke(Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<Expr,Results>>, Results, DecisionTreeTarget)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].targetF(System.__Canon, DecisionTreeTarget)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis.foldUnderLambda[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<System.__Canon,Results>>, Results, System.__Canon)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis+targetIntercept@292.Invoke(Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<Expr,Results>>, Results, DecisionTreeTarget)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].targetF(System.__Canon, DecisionTreeTarget)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis.foldUnderLambda[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<System.__Canon,Results>>, Results, System.__Canon)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis+targetIntercept@292.Invoke(Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<Expr,Results>>, Results, DecisionTreeTarget)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].targetF(System.__Canon, DecisionTreeTarget)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis.foldUnderLambda[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<System.__Canon,Results>>, Results, System.__Canon)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis+targetIntercept@292.Invoke(Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<Expr,Results>>, Results, DecisionTreeTarget)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].targetF(System.__Canon, DecisionTreeTarget)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at FSharp.Compiler.Detuple+GlobalUsageAnalysis.foldUnderLambda[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](Microsoft.FSharp.Core.FSharpFunc`2<Results,Microsoft.FSharp.Core.FSharpFunc`2<System.__Canon,Results>>, Results, System.__Canon)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprF(System.__Canon, Expr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].exprNoInterceptF(System.__Canon, Expr)
   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, IntPtr*), IntPtr)
   at FSharp.Compiler.TypedTreeOps+ExprFolders`1[[Sys
Results File: C:\kevinransom\fsharp\artifacts\TestResults\release\FSharpSuite.Tests_netcoreapp3.1.xml

[KevinRansom]

This is a bug in the jit, it has been fixed, and the fix will ship in dev16.9

[cartermp]

Closing and tagging for 16.9