Revert "Revert "Merge pull request #1920 from dotnet/darc-main-c4635c16-72c5-…" #2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
lewing
approved these changes
Nov 16, 2023
Member
Author
|
(I would have requested as reviewers, but I don't seem to have the capability to do that in this repo) |
jjonescz
approved these changes
Nov 20, 2023
Member
|
Can I merge this or does it need to be coordinated somehow? |
Member
Author
|
@jjonescz We were waiting for the Roslyn integration test issue to be resolved. Plus, runtime had merged theirs ahead of time and I had to revert that. So, I gotta revert that revert once Roslyn is ready. Tracking in this comment: dotnet/sdk#33126 (comment) |
Member
Author
|
@jjonescz This now can be merged immediately. The SDK PR and Runtime PR have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #1983
Summary
This is a coordinated update for
dotnet/command-line-apiin the repos that DARC flows to. There needs to be only 1 version of this dependency for Source Build to function properly. See: dotnet/sdk#33126