Skip to content

Fix KeyNotFoundException in HttpRequestLatencyListener.OnEventWritten #6823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Fix KeyNotFoundException in HttpRequestLatencyListener.OnEventWritten #6823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935f505
Fix KeyNotFoundException in HttpRequestLatencyListener.OnEventWritten
pentp Sep 19, 2025
5ee4854
Merge branch 'main' into es-workaround
pentp Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ibraries/Microsoft.Extensions.Http.Diagnostics.Tests/Latency/Internal/HttpMockProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public static Mock<ILatencyContext> GetLatencyContext()
return lc;
}

public class MockEventSource : EventSource
public class MockEventSource() : EventSource(throwOnEventWriteErrors: true)
{
public int OnEventInvoked;

Expand Down
9 changes: 9 additions & 0 deletions ...soft.Extensions.Http.Diagnostics.Tests/Latency/Internal/HttpRequestLatencyListenerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.Tracing;
using System.Linq;
using Microsoft.Extensions.Diagnostics.Latency;
using Microsoft.Extensions.Http.Latency.Internal;
Expand Down Expand Up @@ -84,8 +85,16 @@ public void HttpRequestLatencyListener_OnEventSourceCreated_NonHttpSources()
listener.OnEventSourceCreated("test", es);
Assert.Equal(0, es.OnEventInvoked);
Assert.False(es.IsEnabled());

using var dummyListener = new DummyListener();
dummyListener.EnableEvents(es, EventLevel.LogAlways);

// EventSource seems to send the event to all listeners, even those that didn't enable the EventSource at all!
es.Write("Dummy");
}

private sealed class DummyListener : EventListener;

[Fact]
public void HttpRequestLatencyListener_OnEventSourceCreated_HttpSources()
{
Expand Down
Loading