Skip to content

Fix KeyNotFoundException on HttpRequestLatencyListener.OnEventWritten for uknown event sources #6821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

Fix KeyNotFoundException on HttpRequestLatencyListener.OnEventWritten for uknown event sources #6821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76273ac
Fix KeyNotFoundException on HttpRequestLatencyListener.OnEventWritten…
ssmelov Sep 19, 2025
b50595b
Update test/Libraries/Microsoft.Extensions.Http.Diagnostics.Tests/Lat…
dariusclay Sep 23, 2025
776c395
Merge branch 'main' into fix_httprequestlatencylistener_oneventwritte…
dariusclay Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ries/Microsoft.Extensions.Http.Diagnostics/Latency/Internal/HttpRequestLatencyListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ public void Enable()
internal void OnEventWritten(string eventSourceName, string? eventName)
{
// If event of interest, add a checkpoint for it.
if (eventName != null && _eventToTokenMap[eventSourceName].TryGetValue(eventName, out var token))
if (eventName != null
&& _eventToTokenMap.TryGetValue(eventSourceName, out var tokenMap)
&& tokenMap.TryGetValue(eventName, out var token))
{
LatencyContext.Get()?.AddCheckpoint(token);
}
Expand Down
15 changes: 15 additions & 0 deletions ...soft.Extensions.Http.Diagnostics.Tests/Latency/Internal/HttpRequestLatencyListenerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,4 +191,19 @@ public void HttpRequestLatencyListener_OnEventWritten_AddsCheckpoints_Http()
lc.Verify(a => a.AddCheckpoint(It.IsAny<CheckpointToken>()),
Times.Exactly(numHttpEvents + numSocketEvents + numDnsEvents));
}

[Fact]
public void HttpRequestLatencyListener_OnEventWritten_DoesNotAddCheckpoints_UnknownEventSource()
{
var lcti = HttpMockProvider.GetTokenIssuer();
var lc = HttpMockProvider.GetLatencyContext();
var context = new HttpClientLatencyContext();
context.Set(lc.Object);

using var listener = HttpMockProvider.GetListener(context, lcti.Object);

listener.OnEventWritten("System.Runtime", "EventCounters");

lc.Verify(a => a.AddCheckpoint(It.IsAny<CheckpointToken>()), Times.Never);
}
}
Loading