Skip to content

AIFunctionFactory: add test coverage for JSON comments. #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

AIFunctionFactory: add test coverage for JSON comments. #6576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1f7276
AIFunctionFactory: add test coverage for JSON comments.
eiriktsarpalis Jul 3, 2025
34034a9
Update src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/A…
eiriktsarpalis Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,8 +1058,7 @@ private record struct DescriptorKey(
( null # null literal
| false # false literal
| true # true literal
| \d # positive number
| -\d # negative number
| -?[0-9]# number
| " # string
| \[ # start array
| { # start object
Expand Down
7 changes: 5 additions & 2 deletions test/Libraries/Microsoft.Extensions.AI.Tests/Functions/AIFunctionFactoryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,13 @@ public async Task Parameters_ToleratesJsonEncodedParameters()
[InlineData(" \"I am a string!\" ")]
[InlineData(" {}")]
[InlineData("[]")]
[InlineData("// single-line comment\r\nnull")]
[InlineData("/* multi-line\r\ncomment */\r\nnull")]
public async Task Parameters_ToleratesJsonStringParameters(string jsonStringParam)
{
AIFunction func = AIFunctionFactory.Create((JsonElement param) => param);
JsonElement expectedResult = JsonDocument.Parse(jsonStringParam).RootElement;
JsonSerializerOptions options = new(AIJsonUtilities.DefaultOptions) { ReadCommentHandling = JsonCommentHandling.Skip };
AIFunction func = AIFunctionFactory.Create((JsonElement param) => param, serializerOptions: options);
JsonElement expectedResult = JsonDocument.Parse(jsonStringParam, new() { CommentHandling = JsonCommentHandling.Skip }).RootElement;

var result = await func.InvokeAsync(new()
{
Expand Down
Loading