AIFunctionFactory: tolerate JSON string function parameters. #6572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Jul 2, 2025
src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionFactory.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 2, 2025
src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionFactory.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 2, 2025
test/Libraries/Microsoft.Extensions.AI.Integration.Tests/ChatClientIntegrationTests.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 2, 2025
test/Libraries/Microsoft.Extensions.AI.Integration.Tests/ChatClientIntegrationTests.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 2, 2025
…IFunctionFactory.cs Co-authored-by: Stephen Toub <[email protected]>
joperezr
pushed a commit
that referenced
this pull request
Jul 8, 2025
* AIFunctionFactory: tolerate JSON string function parameters. * Add debug assertion. * Update src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionFactory.cs Co-authored-by: Stephen Toub <[email protected]> * Add regex-based JSON string recognition and add more tests. --------- Co-authored-by: Stephen Toub <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, SK kernels can pass
KernelArgumentswith parameters formatted as JSON strings toAIFunctions created byAIFunctionFactory, resulting in argument exceptions. This PR updatesAIFunctionFactoryso that JSON strings are tolerated as function parameters.FYI @rogerbarreto @SergeyMenshykh
Fix #6544.
Microsoft Reviewers: Open in CodeFlow