OpenAI: Parse detail additional property #6225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Apr 2, 2025
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Apr 2, 2025
test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/Microsoft.Extensions.AI.OpenAI.Tests.csproj
Show resolved
Hide resolved
stephentoub
reviewed
Apr 2, 2025
test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIChatClientTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Apr 2, 2025
stephentoub
reviewed
Apr 2, 2025
|
|
||
| private static ChatImageDetailLevel? GetImageDetail(AIContent content) | ||
| { | ||
| if (content.AdditionalProperties?.TryGetValue("detail", out string? value) == true) |
There was a problem hiding this comment.
Is it possible someone might try putting a ChatImageDetailLevel into the properties?
There was a problem hiding this comment.
It definitely is possible since AdditionalProperties' TValue is object? and we would be ignoring it.
This is what it would look like:
var imageContent = new UriContent("http://localhost/my-image.png", "image/png")
{
AdditionalProperties = new()
{
{ "detail", OpenAI.Chat.ChatImageDetailLevel.High }
}
};We could match ChatImageDetailLevel as well.
joperezr
pushed a commit
to joperezr/extensions
that referenced
this pull request
Apr 8, 2025
* OpenAI: Parse detail additional property * Update tests to use AsIChatClient * Don't throw when type is not string * Match OpenAI.Chat.ChatImageDetailLevel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6198
Microsoft Reviewers: Open in CodeFlow