Fix grouping of ChatResponseUpdate into ChatMessage #6074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Mar 11, 2025
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponseExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Mar 11, 2025
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponseUpdate.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 11, 2025
joperezr
pushed a commit
to joperezr/extensions
that referenced
this pull request
Mar 11, 2025
* For Ollama client, ensure ToChatResponseAsync coalesces text chunks into a single message * Fix OpenAI case by not treating empty-string response IDs as message boundaries
joperezr
pushed a commit
to joperezr/extensions
that referenced
this pull request
Mar 11, 2025
…otnet#6074) Fix grouping of ChatResponseUpdate into ChatMessage (dotnet#6074) * For Ollama client, ensure ToChatResponseAsync coalesces text chunks into a single message * Fix OpenAI case by not treating empty-string response IDs as message boundaries
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Ollama, it was broken because it set a new ResponseId for every chunk. It now correctly sets per-response IDs.
For OpenAI, it had a minor issue with handling empty-string ResponseId values. It now treats this case as equivalent to null ResponseId values, and thereby avoids introducing extra blank messages.
Microsoft Reviewers: Open in CodeFlow