Skip to content

Enable API compat validation #5871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Enable API compat validation #5871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@
<Deterministic>true</Deterministic>
<Features>debug-determinism</Features>

<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/overview -->
<EnablePackageValidation>true</EnablePackageValidation>

<EnableXlfLocalization>false</EnableXlfLocalization>
<UpdateXlfOnBuild>false</UpdateXlfOnBuild>

Expand Down
9 changes: 9 additions & 0 deletions eng/MSBuild/Packaging.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@
<None Condition=" '$(IsPackable)' == 'true' and '$(IsShipping)' == 'true' " Include="README.md" Pack="true" PackagePath="\" />
</ItemGroup>


<PropertyGroup Condition=" '$(EnablePackageValidation)' != 'false' and '$(IsPackable)' == 'true' and '$(IsShipping)' == 'true' and '$(Api)' != 'false' ">
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/overview -->
<EnablePackageValidation>true</EnablePackageValidation>

<PackageValidationBaselineVersion Condition=" '$(Stage)' == 'normal' ">$(ApiCompatBaselineVersion)</PackageValidationBaselineVersion>
<PackageValidationBaselineVersion Condition=" '$(Stage)' == 'preview' ">$(ApiCompatBaselineVersion)$(ApiCompatBaselineSuffix)</PackageValidationBaselineVersion>
</PropertyGroup>

<!-- Verify that the minimum supported TFM is actually used. -->
<Target Name="_VerifyMinimumSupportedTfmForPackagingIsUsed"
Condition="'$(IsPackable)' == 'true' and '$(DisableNETStandardCompatErrors)' != 'true'">
Expand Down
3 changes: 2 additions & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<PreReleaseVersionIteration>1</PreReleaseVersionIteration>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<ValidateBaseline>true</ValidateBaseline>
<ApiCompatBaselineVersion>9.2.0</ApiCompatBaselineVersion>
<ApiCompatBaselineSuffix>-preview.1.25105.6</ApiCompatBaselineSuffix>
<AssemblyVersion>$(MajorVersion).$(MinorVersion).0.0</AssemblyVersion>
<!--
When DotNetFinalVersionKind is set to 'release', this branch will produce stable outputs for 'Shipping' packages
Expand Down
1 change: 1 addition & 0 deletions ...ibraries/Microsoft.Extensions.AI.Abstractions/Microsoft.Extensions.AI.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<PropertyGroup>
<Stage>preview</Stage>
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
<EnablePackageValidation>false</EnablePackageValidation>
Copy link
Contributor Author

@RussKie RussKie Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shyamnamboodiripad FYI, you may need to apply the same to the Eval projects under /src/Libraries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the heads up! That probably explains why recent builds in #5873 have been failing...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I have cycles, I'll look into generalising MSBuild configs that are required for each AI project.

<MinCodeCoverage>83</MinCodeCoverage>
<MinMutationScore>0</MinMutationScore>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions .../Microsoft.Extensions.AI.AzureAIInference/Microsoft.Extensions.AI.AzureAIInference.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<PropertyGroup>
<Stage>preview</Stage>
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
<EnablePackageValidation>false</EnablePackageValidation>
<MinCodeCoverage>91</MinCodeCoverage>
<MinMutationScore>0</MinMutationScore>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.Ollama/Microsoft.Extensions.AI.Ollama.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<PropertyGroup>
<Stage>preview</Stage>
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
<EnablePackageValidation>false</EnablePackageValidation>
<MinCodeCoverage>80</MinCodeCoverage>
<MinMutationScore>0</MinMutationScore>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.OpenAI/Microsoft.Extensions.AI.OpenAI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<PropertyGroup>
<Stage>preview</Stage>
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
<EnablePackageValidation>false</EnablePackageValidation>
<MinCodeCoverage>77</MinCodeCoverage>
<MinMutationScore>0</MinMutationScore>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI/Microsoft.Extensions.AI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<PropertyGroup>
<Stage>preview</Stage>
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
<EnablePackageValidation>false</EnablePackageValidation>
<MinCodeCoverage>88</MinCodeCoverage>
<MinMutationScore>0</MinMutationScore>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/ProjectTemplates/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
<NoWarn>$(NoWarn);SA1633;CS1591</NoWarn>
<SkipAnalyzers>true</SkipAnalyzers>
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
<Api>false</Api>
</PropertyGroup>
</Project>