Skip to content

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Feb 4, 2025

Fixes some issues that unblock local development:

  1. Add a launchSettings.json file. Without this, the environment defaults to Production and this causes the page to fail to load when running with dotnet run.
  2. Fix the TailwindBuild target to always run after the BuildNpmDependencies target. This just required changing the AfterTargets to a DependsOnTargets.
Microsoft Reviewers: Open in CodeFlow

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner February 4, 2025 00:03
@MackinnonBuck MackinnonBuck requested review from SteveSandersonMS and removed request for a team February 4, 2025 00:04
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI.OpenAI 77 78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=938914&view=codecoverage-tab

@SteveSandersonMS
Copy link
Member

Excellent - thanks!

I don't know how much difference it makes but the ASP.NET Core templates also do something to suppress these kestrelHttp(s)Port parameters from appearing in the CLI: https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/.template.config/dotnetcli.host.json#L11-L16

If you think it's reasonable to copy that pattern here that's great, but like I say I'm not certain what impact it has.

@MackinnonBuck
Copy link
Member Author

If you think it's reasonable to copy that pattern here that's great, but like I say I'm not certain what impact it has.

Yep, seems reasonable to me 🙂

@MackinnonBuck MackinnonBuck enabled auto-merge (squash) February 4, 2025 17:52
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI.Abstractions 83 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=939731&view=codecoverage-tab

@MackinnonBuck MackinnonBuck merged commit ab94e0b into main Feb 4, 2025
6 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/small-template-fixes branch February 4, 2025 18:24
@jeffhandley jeffhandley added the area-ai-templates Microsoft.Extensions.AI.Templates label Mar 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ai-templates Microsoft.Extensions.AI.Templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants