Skip to content

Add Obsolete attribute on IResourceMonitor and its friends #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add Obsolete attribute on IResourceMonitor and its friends #5774

merged 2 commits into from
Jan 16, 2025

Conversation

evgenyfedorov2
Copy link
Member

@evgenyfedorov2 evgenyfedorov2 commented Jan 6, 2025 •
edited by dotnet-policy-service bot
Loading

Resolves #5773

Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2 evgenyfedorov2 requested review from a team as code owners January 6, 2025 12:46
@amadeuszl
Copy link
Contributor

There's SourceIpAddresses in ResourceMonitoringOptions.Windows that I believe should be Obsolete as well

@amadeuszl
Copy link
Contributor

Could we specify in readme (unless there's some guide somewhere else) what's obsolete and what's new recommended way of the library usage? It may be quite important as at least half of the codebase of the library will be obsolete at this point.

@evgenyfedorov2
Copy link
Member Author

evgenyfedorov2 commented Jan 8, 2025 •
edited
Loading

There's SourceIpAddresses in ResourceMonitoringOptions.Windows that I believe should be Obsolete as well

I did not make it obsolete intentionally because it is used in WindowsTcpStateInfo, which is not related to IResourceMonitor. It should stay because it is relevant for .NET Metrics

@evgenyfedorov2
Copy link
Member Author

Could we specify in readme (unless there's some guide somewhere else) what's obsolete and what's new recommended way of the library usage? It may be quite important as at least half of the codebase of the library will be obsolete at this point.

We already provide quick Diagnostics IDs here. Conceptual documentation of Resource Monitoring is here and of course it will need to be updated too, but it is a different repo, so created an issue there. Is this what you are suggesting or is it something different?

amadeuszl
amadeuszl approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@amadeuszl amadeuszl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no more questions

@evgenyfedorov2 evgenyfedorov2 merged commit 8f15b0f into dotnet:main Jan 16, 2025
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amadeuszl amadeuszl amadeuszl approved these changes

Assignees

@evgenyfedorov2 evgenyfedorov2

Labels
area-telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Obsolete attribute to public API which use IResourceMonitor
2 participants
@evgenyfedorov2 @amadeuszl