Update the meter names of NetworkMetrics to match other meters in ResourceMonitoring #5541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evgenyfedorov2 please help review, thanks |
|
I believe this change is a low-risk, because people are likely to use both |
evgenyfedorov2
approved these changes
Oct 19, 2024
RussKie
approved these changes
Oct 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5537.
Changes the meter name in
WindowsNetworkMetrics.cstoMicrosoft.Extensions.Diagnostics.ResourceMonitoringto match the meter name inWindowsContainerSnapshotProvider.cs.And the Linux one as well.
Related to #5403 and #5404.
Microsoft Reviewers: Open in CodeFlow