Skip to content

Set WriteIndented=true for M.E.AI logging / telemetry / etc. #5497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

Set WriteIndented=true for M.E.AI logging / telemetry / etc. #5497

merged 1 commit into from
Oct 10, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Oct 10, 2024 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner October 10, 2024 01:30
@stephentoub stephentoub added the area-ai Microsoft.Extensions.AI libraries label Oct 10, 2024
eiriktsarpalis
eiriktsarpalis approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With STJ 9 we can also customize the indentation char and level assuming we have evidence of a particular configuration being conducive to LLMs.

@eiriktsarpalis eiriktsarpalis merged commit 221449d into dotnet:main Oct 10, 2024
6 checks passed
@stephentoub stephentoub deleted the prettyprintjson branch October 26, 2024 02:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

+1 more reviewer

@RussKie RussKie RussKie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@stephentoub stephentoub

Labels
area-ai Microsoft.Extensions.AI libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @eiriktsarpalis @RussKie