Integrate ApplyStartupHook into Dotnet-Monitor
#4783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kkeirstead/AddStartupHookExperimenting
ghost
added
the
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/ExceptionsPipelineTests.cs
Show resolved
Hide resolved
kkeirstead
commented
Jun 29, 2023
…de so that we separately attempt to apply the startup hook once, instead of every time we check whether it has been set.
src/Microsoft.Diagnostics.Monitoring.WebApi/IExperimentalFlags.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.WebApi/IInProcessFeatures.cs
Outdated
Show resolved
Hide resolved
kkeirstead
commented
Jul 11, 2023
jander-msft
reviewed
Jul 11, 2023
jander-msft
reviewed
Jul 11, 2023
src/Tools/dotnet-monitor/StartupHook/StartupHookEndpointInfoSourceCallback.cs
Outdated
Show resolved
Hide resolved
…tly does not work for applying startup hook - more changes will be needed.
jander-msft
reviewed
Jul 12, 2023
src/Tools/dotnet-monitor/StartupHook/StartupHookEndpointInfoSourceCallback.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Jul 13, 2023
src/Tools/dotnet-monitor/StartupHook/StartupHookEndpointInfoSourceCallback.cs
Show resolved
Hide resolved
jander-msft
reviewed
Jul 13, 2023
jander-msft
reviewed
Jul 13, 2023
src/Tools/dotnet-monitor/InProcessFeatures/InProcessFeatures.cs
Outdated
Show resolved
Hide resolved
jander-msft
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds on @jander-msft 's changes in the runtime - this allows dotnet-monitor to automatically set the startup hook (instead of requiring users to manually set it themselves).
Release Notes Entry