-
Notifications
You must be signed in to change notification settings - Fork 1.6k
itemsInBags will be different from 500 #8043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
itemsInBags will be different 500 without atomic operation.
|
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsitemsInBags will be different 500 without atomic operation. SummaryDescribe your changes here. Fixes #Issue_Number (if available)
|
|
Docs Build status updates of commit 02192cf: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this change @chenkaigithub
Once you make one addition, this is ready merge.
Thanks again!
| { | ||
| Console.WriteLine(item); | ||
| itemsInBag++; | ||
| Interlocked.Increment(ref itemsInBag); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs the following using statement to compile correctly:
using System.Threading;
Once you add that, we'll ![]()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I updated.
Add using System.Threading for function used.
|
Docs Build status updates of commit a599ce2: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
itemsInBags will be different 500 without atomic operation.
Summary
Describe your changes here.
Fixes #8043 (if available)