Skip to content

Remove CAS attributes #8011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2022
Merged

Remove CAS attributes #8011

merged 2 commits into from
Apr 29, 2022

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 28, 2022

Contributes to dotnet/docs#29143

  • Removes CAS attributes from code snippets
  • Removes remarks about security demands (I assume these are no longer relevant for .NET 5+)

@ghost ghost added the area-Infrastructure label Apr 28, 2022
@opbld31
Copy link

opbld31 commented Apr 28, 2022

Docs Build status updates of commit 8c65e3a:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/ActivationContext/Overview/program.cs ✅Succeeded View
snippets/csharp/System/AppDomain/UnhandledException/unhandledexception.cs ✅Succeeded View
snippets/csharp/System/AppDomainManager/Overview/customAppDomainManager.cs ✅Succeeded View
snippets/csharp/System/ApplicationId/Overview/program.cs ✅Succeeded View
snippets/csharp/System/Exception/.ctor/getobjdata.cs ✅Succeeded View
snippets/csharp/System/MarshalByRefObject/InitializeLifetimeService/source.cs ✅Succeeded View
snippets/csharp/System/MarshalByRefObject/Overview/source.cs ✅Succeeded View
snippets/csharp/System/TypeLoadException/.ctor/typeloadexception_getobjectdata.cs ✅Succeeded View
snippets/fsharp/System/AppDomain/UnhandledException/unhandledexception.fs ✅Succeeded View
snippets/fsharp/System/ApplicationId/Overview/program.fs ✅Succeeded View
snippets/fsharp/System/Exception/.ctor/getobjdata.fs ✅Succeeded View
snippets/fsharp/System/MarshalByRefObject/InitializeLifetimeService/source.fs ✅Succeeded View
snippets/fsharp/System/MarshalByRefObject/Overview/source.fs ✅Succeeded View
xml/System/Activator.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Apr 29, 2022

Docs Build status updates of commit c13a099:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/ActivationContext/Overview/Project.csproj ✅Succeeded
snippets/csharp/System/ActivationContext/Overview/program.cs ✅Succeeded View
snippets/csharp/System/AppDomain/UnhandledException/unhandledexception.cs ✅Succeeded View
snippets/csharp/System/AppDomainManager/Overview/Project.csproj ✅Succeeded
snippets/csharp/System/AppDomainManager/Overview/customAppDomainManager.cs ✅Succeeded View
snippets/csharp/System/ApplicationId/Overview/Project.csproj ✅Succeeded
snippets/csharp/System/ApplicationId/Overview/program.cs ✅Succeeded View
snippets/csharp/System/Exception/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System/Exception/.ctor/getobjdata.cs ✅Succeeded View
snippets/csharp/System/Exception/.ctor/news.cs ✅Succeeded View
snippets/csharp/System/MarshalByRefObject/InitializeLifetimeService/Project.csproj ✅Succeeded
snippets/csharp/System/MarshalByRefObject/InitializeLifetimeService/source.cs ✅Succeeded View
snippets/csharp/System/MarshalByRefObject/Overview/Project.csproj ✅Succeeded
snippets/csharp/System/MarshalByRefObject/Overview/source.cs ✅Succeeded View
snippets/csharp/System/TypeLoadException/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System/TypeLoadException/.ctor/typeloadexception_constructor3.cs ✅Succeeded View
snippets/csharp/System/TypeLoadException/.ctor/typeloadexception_getobjectdata.cs ✅Succeeded View
snippets/fsharp/System/AppDomain/UnhandledException/unhandledexception.fs ✅Succeeded View
snippets/fsharp/System/ApplicationId/Overview/program.fs ✅Succeeded View
snippets/fsharp/System/Exception/.ctor/getobjdata.fs ✅Succeeded View
snippets/fsharp/System/MarshalByRefObject/InitializeLifetimeService/source.fs ✅Succeeded View
snippets/fsharp/System/MarshalByRefObject/Overview/source.fs ✅Succeeded View
xml/System/Activator.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren marked this pull request as ready for review April 29, 2022 00:10
@gewarren gewarren requested a review from a team as a code owner April 29, 2022 00:10
BillWagner
BillWagner approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit bb47b47 into dotnet:main Apr 29, 2022
@gewarren gewarren deleted the cas-five branch April 29, 2022 18:11
@gewarren
Copy link
Contributor Author

gewarren commented Apr 29, 2022

Thanks for reviewing these, @BillWagner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gewarren @opbld31 @opbld30 @BillWagner