CI Update - .NET 7 Preview 3 APIs #8000
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=289998&view=results source_repo.branch:net7-pre3 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
gewarren
requested review from
a team,
AaronRobinsonMSFT,
David-Engel,
JRahnama,
Rick-Anderson,
RussKie,
ajcvickers,
jkoritzinsky,
kouvel and
merriemcgaw
as code owners
ghost
added
the
area-Meta
This comment was marked as outdated.
This comment was marked as outdated.
| <AttributeName Language="F#">[<System.Obsolete("This interface has been deprecated. Add a TypeDescriptionProvider to handle type TypeDescriptor.ComObjectType instead. https://go.microsoft.com/fwlink/?linkid=14202")>]</AttributeName> | ||
| </Attribute> | ||
| <Attribute FrameworkAlternate="net-7.0"> | ||
| <AttributeName Language="C#">[System.Obsolete("IComNativeDescriptorHandler has been deprecated. Add a TypeDescriptionProvider to handle type TypeDescriptor.ComObjectType instead.")]</AttributeName> |
There was a problem hiding this comment.
This is just a change in the obsoletion message for .NET 7 (from dotnet/runtime@895c99c). I think we have the ability to show different messages in different versions now.
| <AttributeName Language="F#">[<System.AttributeUsage(System.AttributeTargets.Assembly | System.AttributeTargets.Class | System.AttributeTargets.Constructor | System.AttributeTargets.Method | System.AttributeTargets.Struct, AllowMultiple=true, Inherited=false)>]</AttributeName> | ||
| </Attribute> | ||
| <Attribute FrameworkAlternate="dotnet-plat-ext-5.0;windowsdesktop-5.0;windowsdesktop-6.0;windowsdesktop-7.0"> | ||
| <Attribute FrameworkAlternate="dotnet-plat-ext-5.0;dotnet-plat-ext-7.0;windowsdesktop-5.0;windowsdesktop-6.0;windowsdesktop-7.0"> |
There was a problem hiding this comment.
I'm not sure why dotnet-plat-ext-6.0 doesn't appear here.
There was a problem hiding this comment.
Why were you expecting that moniker for this API specifically?
I assume the contents of this PR are generated using mdoc. Do we have control over which monikers to include? For example, the Continuous Integration job for Intellisense has a textbox where we can manually indicate the monikers we want to include:
There was a problem hiding this comment.
It's weird that this type would show as obsolete in .NET 5 and .NET 7, but not .NET 6. So you won't see the CAUTION block for the obsoletion if you choose the .NET 6 moniker: https://review.docs.microsoft.com/en-us/dotnet/api/system.data.odbc.odbcpermissionattribute?view=dotnet-plat-ext-6.0&branch=pr-en-us-8000.
But it looks like the attribute was only added in src in February, so this is correct.
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=289998&view=results
source_repo.branch:net7-pre3
source_repo.url:https://apidrop.visualstudio.com/_git/binaries