Skip to content

Conversation

@jeffhandley
Copy link
Member

@jeffhandley jeffhandley commented Apr 9, 2022

Regenerate the fabricbot config file to capture the latest output from dotnet/fabricbot-config. This reflects that @ViktorHofer is back and replaces @bartonjs on the libraries infrastructure pod with @carlossanlop.

Regenerated from dotnet/fabricbot-config#22

Updates included:

  1. Viktor is back and replaces Jeremy on the infrastructure pod
  2. The taskSource property is included in the generated configs
  3. The area pods are sorted alphabetically by first name of the members
  4. The task names were renamed
  5. The fix for resurrecting archived cards when they get new updates is applied

Changes 2-5 were from previous changes to fabricbot-config that had not been applied here yet. This gets the repo caught up with the latest.

@jeffhandley jeffhandley added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Apr 9, 2022
@jeffhandley jeffhandley requested a review from carlossanlop April 9, 2022 00:06
@jeffhandley jeffhandley self-assigned this Apr 9, 2022
@jeffhandley jeffhandley requested a review from a team as a code owner April 9, 2022 00:06
@opbld32
Copy link

opbld32 commented Apr 9, 2022

Docs Build status updates of commit 24b0ba0:

✅ Validation status: passed

File Status Preview URL Details
.github/fabricbot.json ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there are many more changes than just adding Viktor back. Are they showing as diffs because they were shuffled to different locations in the file, or are they actual new changes? It's a bit difficult to determine. If it's the latter, I think the PR description should also explain those changes.

@jeffhandley
Copy link
Member Author

Thanks, @carlossanlop. I've updated the description. Basically, this repo was behind on getting some of the config updates applied; this gets it caught up.

@jeffhandley jeffhandley enabled auto-merge (squash) April 9, 2022 07:52
@jeffhandley jeffhandley merged commit 467e244 into dotnet:main Apr 11, 2022
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the PR description the changes look good. Of course I didn't review the whole json :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants