Skip to content

Conversation

@sabarish98
Copy link
Contributor

Summary

Changed summary for FileSystemInfo.LinkTarget to provide better clarity on the property.

Fixes dotnet/runtime#62166

Changed summary for FileSystemInfo.LinkTarget
@sabarish98 sabarish98 requested a review from a team as a code owner January 29, 2022 18:02
@ghost ghost added the area-System.IO label Jan 29, 2022
@ghost
Copy link

ghost commented Jan 29, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Changed summary for FileSystemInfo.LinkTarget to provide better clarity on the property.

Fixes dotnet/runtime#62166

Author: sabarish98
Assignees: -
Labels:

area-System.IO

Milestone: -

@opbld32
Copy link

opbld32 commented Jan 29, 2022

Docs Build status updates of commit 14dabef:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/FileSystemInfo.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the instance represents a link, then wouldn't a link have to exist at FullName? I think these are one and the same?

@sabarish98
Copy link
Contributor Author

If the instance represents a link, then wouldn't a link have to exist at FullName? I think these are one and the same?

@gewarren : Yes, that's correct. But when we work with file paths dynamically, I feel we will use FullName to find the full path since we don't know with what value the instance was created with. So, I feel, it's valid to tell that.

Addressed review changes and added value
@opbld30
Copy link

opbld30 commented Feb 1, 2022

Docs Build status updates of commit ee5a83a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/FileSystemInfo.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@sabarish98
Copy link
Contributor Author

@gewarren : What more do we need to do to get this change merged. Do we need another review?

@gewarren
Copy link
Contributor

gewarren commented Feb 4, 2022

@gewarren : What more do we need to do to get this change merged. Do we need another review?

I'd like to get a review form @jozkee before we merge.

Removed symbolic word
@opbld32
Copy link

opbld32 commented Feb 7, 2022

Docs Build status updates of commit 4f83deb:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/FileSystemInfo.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@jozkee jozkee merged commit 53c0cf5 into dotnet:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear documentation for FileSystemInfo.LinkTarget

5 participants