-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update FileSystemInfo.xml #7665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed summary for FileSystemInfo.LinkTarget
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsSummaryChanged summary for FileSystemInfo.LinkTarget to provide better clarity on the property. Fixes dotnet/runtime#62166
|
|
Docs Build status updates of commit 14dabef: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the instance represents a link, then wouldn't a link have to exist at FullName? I think these are one and the same?
@gewarren : Yes, that's correct. But when we work with file paths dynamically, I feel we will use FullName to find the full path since we don't know with what value the instance was created with. So, I feel, it's valid to tell that. |
Addressed review changes and added value
|
Docs Build status updates of commit ee5a83a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
|
@gewarren : What more do we need to do to get this change merged. Do we need another review? |
Removed symbolic word
|
Docs Build status updates of commit 4f83deb: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Summary
Changed summary for FileSystemInfo.LinkTarget to provide better clarity on the property.
Fixes dotnet/runtime#62166