Skip to content

Conversation

@carlossanlop
Copy link
Contributor

This PR is part of a monthly effort to port triple slash documentation to docs.

Area owners to review:

  • Microsoft.Extensions.Hosting: @dotnet/area-extensions-hosting
  • System.Reflection.Metadata: @dotnet/area-system-reflection-metadata
  • System.Runtime.Intrinsics.X86: @dotnet/area-system-runtime-intrinsics
  • System.Threading: @mangod9 @kouvel

Past PRs:

cc @jeffhandley

@carlossanlop carlossanlop requested review from a team, gewarren and kouvel January 18, 2022 17:20
@carlossanlop carlossanlop self-assigned this Jan 18, 2022
@ghost
Copy link

ghost commented Jan 18, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld31

This comment has been minimized.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hosting LGTM

Copy link
Contributor

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Threading LGTM

Co-authored-by: Genevieve Warren <[email protected]>
@opbld32

This comment has been minimized.

<related type="Article" href="/dotnet/standard/threading/cancellation-in-managed-threads">Cancellation</related>
<related type="Article" href="/dotnet/standard/parallel-programming/task-cancellation">Task Cancellation</related>
<related type="Article" href="/dotnet/standard/parallel-programming/how-to-cancel-a-task-and-its-children">How to: Cancel a Task and Its Children</related>
<exception cref="T:System.ObjectDisposedException">The associated <see cref="T:System.Threading.CancellationTokenSource"/> has been disposed.</exception>
Copy link
Contributor

@buyaa-n buyaa-n Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't throw this exception and i removed it recently, apparently we need update the doc in the runtime repo

Suggested change
<exception cref="T:System.ObjectDisposedException">The associated <see cref="T:System.Threading.CancellationTokenSource"/> has been disposed.</exception>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for letting me know. I'll revert the changes in this file.

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Reflection.Metadata LGTM

@opbld33
Copy link

opbld33 commented Jan 18, 2022

Docs Build status updates of commit cc97e81:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Hosting/BackgroundService.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/HostBuilder.xml ✅Succeeded View
xml/System.Reflection.Metadata/AssemblyExtensions.xml ✅Succeeded View
xml/System.Runtime.Intrinsics.X86/Sse41.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit 5361fe1 into dotnet:main Jan 19, 2022
@carlossanlop carlossanlop deleted the dic21jan22 branch January 19, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants