-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add see also links to conceptual docs #7510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes LGTM. I just added a missing returns, if you don't mind including it in this PR. Feel free to reword it if necessary.
BTW, the area-System.Diagnostics.PerformanceCounter does not yet exist in dotnet-api-docs, but it does exist in runtime. I'm going to create it in this repo and make sure the label automatically adds the code owners.
| <Docs> | ||
| <summary>Observe() fetches the current measurements being tracked by this observable counter.</summary> | ||
| <summary>Fetches the current measurements being tracked by this observable counter.</summary> | ||
| <returns>To be added.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any objections to adding the missing returns value, since we're already here?:
| <returns>To be added.</returns> | |
| <returns>An enumeration of measurements of type `<typeparamref name="T"/>` that are being tracked by this observable counter.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since T isn't listed as a typeparam, presumably because it's not specified by the caller, do you think it's okay to use typeparamref?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess because this is a sealed class, these custom comments don't show up anyway. Only inherited members are shown.
|
Tagging subscribers to this area: @tommcdon Issue DetailsContributes to #7451.
|
Co-authored-by: Carlos Sanchez <[email protected]>
|
Docs Build status updates of commit 00ccca4: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Contributes to #7451.