Current thread culture -> current culture #7410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-Meta
tarekgh
reviewed
Nov 20, 2021
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTime.ToString/vb/ToString1.vb
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Nov 20, 2021
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTime.ToString/vb/ToString1.vb
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Nov 20, 2021
Member
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
I left some little comments. LGTM otherwise. Thanks a lot for getting this cleaned up!
This comment has been minimized.
This comment has been minimized.
BillWagner
approved these changes
Nov 23, 2021
This comment has been minimized.
This comment has been minimized.
|
Docs Build status updates of commit 3ec0ea0:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System/DateTime.xml | View | Details | |
| samples/snippets/csharp/VS_Snippets_CLR_System/system.DateTime.ToString/cs/ToString1.cs | ✅Succeeded | View | |
| samples/snippets/csharp/VS_Snippets_CLR_System/system.DateTime.ToString/cs/ToString2.cs | ✅Succeeded | View | |
| samples/snippets/csharp/VS_Snippets_CLR_System/system.DateTime.ToString/cs/ToString4.cs | ✅Succeeded | View | |
| samples/snippets/csharp/VS_Snippets_CLR_System/system.DateTime.ToString/cs/tostring.csproj | ✅Succeeded | ||
| samples/snippets/csharp/VS_Snippets_CLR_System/system.DateTime.ToString/cs/tostring3.cs | ✅Succeeded | View | |
| samples/snippets/csharp/VS_Snippets_CLR_System/system.DateTime.ToString/cs/tostring5.cs | ✅Succeeded | View | |
| samples/snippets/csharp/VS_Snippets_CLR_System/system.Globalization.CultureInfo.CurrentCulture2/CS/currentculture.cs | ✅Succeeded | View | |
| samples/snippets/csharp/VS_Snippets_CLR_System/system.Globalization.CultureInfo.CurrentCulture2/CS/currentculture.csproj | ✅Succeeded | ||
| samples/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTime.ToString/vb/ToString1.vb | ✅Succeeded | View | |
| samples/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTime.ToString/vb/ToString2.vb | ✅Succeeded | View | |
| samples/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTime.ToString/vb/ToString4.vb | ✅Succeeded | View | |
| samples/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTime.ToString/vb/tostring.vbproj | ✅Succeeded | ||
| samples/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTime.ToString/vb/tostring3.vb | ✅Succeeded | View | |
| samples/snippets/visualbasic/VS_Snippets_CLR_System/system.DateTime.ToString/vb/tostring5.vb | ✅Succeeded | View | |
| samples/snippets/visualbasic/VS_Snippets_CLR_System/system.Globalization.CultureInfo.CurrentCulture2/VB/currentculture.vb | ✅Succeeded | View | |
| samples/snippets/visualbasic/VS_Snippets_CLR_System/system.Globalization.CultureInfo.CurrentCulture2/VB/currentculture.vbproj | ✅Succeeded | ||
| xml/System.Globalization/CultureAndRegionInfoBuilder.xml | ✅Succeeded | View | |
| xml/System.Globalization/CultureInfo.xml | ✅Succeeded | View | |
| xml/System.Globalization/DateTimeFormatInfo.xml | ✅Succeeded | View | |
| xml/System.Globalization/HebrewCalendar.xml | ✅Succeeded | View | |
| xml/System.Globalization/NumberFormatInfo.xml | ✅Succeeded | View | |
| xml/System.Numerics/Vector2.xml | ✅Succeeded | View | |
| xml/System.Numerics/Vector3.xml | ✅Succeeded | View | |
| xml/System.Numerics/Vector4.xml | ✅Succeeded | View | |
| xml/System.Numerics/Vector`1.xml | ✅Succeeded | View | |
| xml/System/Convert.xml | ✅Succeeded | View | |
| xml/System/Double.xml | ✅Succeeded | View | |
| xml/System/FormatException.xml | ✅Succeeded | View |
xml/System/DateTime.xml
- Line 0, Column 0: [Warning: invalid-code]
It looks like your code snippet was not rendered. Try range instead.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
Contributor
Author
|
Close/reopen to build with latest commit. |
|
Docs Build status updates of commit eaefd65: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed all instances of the phrase "current thread culture" to "current culture", except in this section: https://docs.microsoft.com/en-us/dotnet/api/system.globalization.cultureinfo?view=net-6.0#Threads.
In most cases, I didn't update code snippets to call CultureInfo.CurrentCulture instead of Thread.CurrentThread.CurrentCulture. I added project files for the snippets I did update, which meant I had to uniquify class and method names.
Fixes #7331.