Add missing documentation for new SuppressMessage scope #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "namespaceanddescendants" scope was recently supported by Roslyn ([issue 486](dotnet/roslyn#486)). The user guide at [/visualstudio/code-quality/in-source-suppression-overview](https://docs.microsoft.com/en-us/visualstudio/code-quality/in-source-suppression-overview?view=vs-2019#suppressmessage-attribute) already documents this new supported scope, however, it's missing here.
mairaw
requested changes
Oct 2, 2019
xml/System.Diagnostics.CodeAnalysis/SuppressMessageAttribute.xml
Outdated
Show resolved
Hide resolved
mairaw
added
the
✨ 1st-time dotnet-api-docs contributor!
gewarren
approved these changes
Oct 2, 2019
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
LGTM with Maira's suggestions. Thanks!
Use oxford commas, indicate that this scope is only supported in newer versions of Visual Studio. Co-Authored-By: Maira Wenzel <[email protected]>
Contributor
|
@mairaw Your requested changes have been made. I think this is good to merge. |
mairaw
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added missing supported value for the
SuppressMessageAttribute.Scopeproperty.The "namespaceanddescendants" scope was recently supported by Roslyn (issue 486).
The user guide at /visualstudio/code-quality/in-source-suppression-overview already documents this new supported scope, however, it's missing here.