Automatically port ReadOnlySpan.GetPinnableReference #3179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
rpetrusha
suggested changes
Sep 18, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I've suggested some changes, @carlossanlop.
| <Docs> | ||
| <summary>To be added.</summary> | ||
| <returns>To be added.</returns> | ||
| <summary>A read-only reference to an object of type T that can be used for pinning, and is required to support the use of span within a fixed statement.</summary> |
There was a problem hiding this comment.
Suggested change
| <summary>A read-only reference to an object of type T that can be used for pinning, and is required to support the use of span within a fixed statement.</summary> | |
| <summary>A read-only reference to an object of type <typeparamref>T</typeparamref> that can be used for pinning. It is required to support the use of a span within a <code>fixed</code> statement.</summary> |
Contributor
Author
There was a problem hiding this comment.
@rpetrusha shouldn't we be using <typeparamref name="T" /> instead? Or are both valid? I ask because this is the first time I see this format.
There was a problem hiding this comment.
Sorry, @carlossanlop. Yes, we should be using <typeparmref name="T" />. I'm not sure what I was thinking.
Co-Authored-By: Ron Petrusha <[email protected]>
rpetrusha
approved these changes
Sep 26, 2019
|
Thanks for the additional changes, @carlossanlop. I'll merge your PR now. |
mairaw
removed
the
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and return.