Automatically port System.Text.Encodings #3151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
GrabYourPitchforks,
ahsonkhan,
jozkee,
mairaw and
rpetrusha
ahsonkhan
reviewed
Sep 9, 2019
jozkee
reviewed
Sep 9, 2019
Co-Authored-By: David Cantu <[email protected]>
rpetrusha
suggested changes
Sep 9, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I've suggested some changes, @carlossanlop. In particular (and perhaps it's just me), I found the reversal of true and false values confusing, since the initial description of the parameter value describes what the named parameter is not.
ahsonkhan
reviewed
Sep 9, 2019
ahsonkhan
reviewed
Sep 9, 2019
ahsonkhan
approved these changes
Sep 9, 2019
Contributor
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
Other than those changes, look's good.
Co-Authored-By: Ron Petrusha <[email protected]>
jozkee
reviewed
Sep 10, 2019
Co-Authored-By: David Cantu <[email protected]>
carlossanlop
added
changes-addressed
ahsonkhan
approved these changes
Sep 10, 2019
rpetrusha
approved these changes
Sep 10, 2019
mairaw
removed
the
changes-addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ahsonkhan @GrabYourPitchforks