Skip to content

Conversation

ryalanms
Copy link
Member

Fixes dotnet/wpf#1172. Note that there are no new WPF APIs for .NET Core.

@carlossanlop carlossanlop added the 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 label Aug 15, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 15, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a number of edits, @ryalanms. Please review them.

</Base>
<Docs>
<summary>Describes the shape at the ends of each dash segment.</summary>
<summary>Describes the shape at the end of each dash segment.</summary>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick here: both ends of each dash are affected by the cap setting.

Copy link
Contributor

@carlossanlop carlossanlop Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which cap setting are you referring to? Should this information be included as a remark somewhere within this file?

Copy link
Member Author

@ryalanms ryalanms Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PenDashCap (this enum) is the shape (the line cap) at the ends of each dash segment. If that doesn't seem clear, 'line cap' can be added to the main description:

 <summary>Describes the shape (the line cap) at the ends of each dash segment.</summary>

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving. I left 3 small suggestions (spacing).

@mairaw
Copy link
Contributor

mairaw commented Aug 16, 2019

There are some warnings on the PR. I'll have to check later from home. I have a hard stop now.

@rpetrusha rpetrusha merged commit 7d8351c into dotnet:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document new API's

4 participants