-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add documentation for WPF's System.Windows.Media.PenDashCap enum and System.Windows.Media.IAnimation interface #3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…System.Windows.Media.IAnimation interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a number of edits, @ryalanms. Please review them.
</Base> | ||
<Docs> | ||
<summary>Describes the shape at the ends of each dash segment.</summary> | ||
<summary>Describes the shape at the end of each dash segment.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick here: both ends of each dash are affected by the cap setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which cap setting are you referring to? Should this information be included as a remark somewhere within this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PenDashCap (this enum) is the shape (the line cap) at the ends of each dash segment. If that doesn't seem clear, 'line cap' can be added to the main description:
<summary>Describes the shape (the line cap) at the ends of each dash segment.</summary>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approving. I left 3 small suggestions (spacing).
There are some warnings on the PR. I'll have to check later from home. I have a hard stop now. |
Fixes dotnet/wpf#1172. Note that there are no new WPF APIs for .NET Core.