-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added documentation for System.Text.Rune struct #2943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@GrabYourPitchforks note that I am referring to |
carlossanlop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, @jozkee.
rpetrusha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that the explicit conversion description with "Defines an explicit conversion..." is good, @jozkee. I also noted where exceptions should be documented.
jozkee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding exceptions for op_Explicit
Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
|
@rpetrusha I've addressed the feedback. Please tell me if something else is missing. Also plese verify the wording in the exceptions added to op_Explicit. |
carlossanlop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
This looks good, @jozkee. Thanks for making the additional changes. I'll merge now. |
Documented APIs: