Skip to content

Conversation

@jozkee
Copy link
Member

@jozkee jozkee commented Aug 6, 2019

Documented APIs:

  • op_Equality(System.Text.Rune,System.Text.Rune)
  • op_Explicit(System.UInt32)~System.Text.Rune
  • op_Explicit(System.Char)~System.Text.Rune
  • op_Explicit(System.Int32)~System.Text.Rune
  • op_GreaterThan(System.Text.Rune,System.Text.Rune)
  • op_GreaterThanOrEqual(System.Text.Rune,System.Text.Rune)
  • op_Inequality(System.Text.Rune,System.Text.Rune)
  • op_LessThan(System.Text.Rune,System.Text.Rune)
  • op_LessThanOrEqual(System.Text.Rune,System.Text.Rune)
  • ToLower(System.Text.Rune,System.Globalization.CultureInfo)
  • ToLowerInvariant(System.Text.Rune)
  • ToUpper(System.Text.Rune,System.Globalization.CultureInfo)
  • ToUpperInvariant(System.Text.Rune)

@jozkee
Copy link
Member Author

jozkee commented Aug 6, 2019

@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 6, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 6, 2019
@jozkee
Copy link
Member Author

jozkee commented Aug 6, 2019

@GrabYourPitchforks note that I am referring to Rune as a 32-bit Unicode character. Please correct me if I am wrong or if we should omit that.

@carlossanlop carlossanlop changed the title Added docuemntation for System.Text.Rune struct Added documentation for System.Text.Rune struct Aug 6, 2019
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, @jozkee.

@carlossanlop carlossanlop removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Aug 6, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the explicit conversion description with "Defines an explicit conversion..." is good, @jozkee. I also noted where exceptions should be documented.

Copy link
Member Author

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding exceptions for op_Explicit

Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
@jozkee
Copy link
Member Author

jozkee commented Aug 7, 2019

@rpetrusha I've addressed the feedback. Please tell me if something else is missing. Also plese verify the wording in the exceptions added to op_Explicit.

@mairaw mairaw added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Aug 7, 2019
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rpetrusha
Copy link

This looks good, @jozkee. Thanks for making the additional changes. I'll merge now.

@rpetrusha rpetrusha merged commit 3651464 into dotnet:master Aug 7, 2019
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants