Document System.Security.Cryptography.Pkcs.SignerInfo #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
GrabYourPitchforks,
bartonjs,
jozkee,
krwq,
mairaw and
rpetrusha
rpetrusha
suggested changes
Aug 6, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I've left a number of suggestions, @carlossanlop.
Co-Authored-By: Ron Petrusha <[email protected]>
carlossanlop
added
changes-addressed
krwq
reviewed
Aug 6, 2019
krwq
reviewed
Aug 6, 2019
krwq
reviewed
Aug 6, 2019
Co-Authored-By: Ron Petrusha <[email protected]>
carlossanlop
commented
Aug 6, 2019
carlossanlop
commented
Aug 6, 2019
Contributor
Author
|
@rpetrusha I addressed the feedback in this PR. Would you mind taking a look at my latest commits in case we need some rewording? |
krwq
approved these changes
Aug 6, 2019
rpetrusha
approved these changes
Aug 6, 2019
|
The changes look good, @carlossanlop. |
Contributor
Author
|
@rpetrusha it's been approved and the build just finished successfully. Can we merge it? |
carlossanlop
added
verify-build-before-merge
and removed
changes-addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document AddUnassignedAttribute and RemoveUnassignedAttribute.
@krwq since you added these two APIs, can you please verify that the language I used to describe these methods is accurate?
Proposal: https://github.com/dotnet/corefx/issues/25449
PR that added the code: dotnet/corefx#29408
Definition of AsnEncodedData: https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.asnencodeddata
Definition of SignerInfo: https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.pkcs.signerinfo