Document System.Security.Cryptography.X509Certificates.X509Certificate2UI

[carlossanlop]

This is not a new API, it was merely ported from Framework to Core: dotnet/corefx#31111
The only API missing documentation was the default constructor.
Adding @Anipik since he ported this class. Is the description of the default constructor good enough for you? It's not explicitly specified in the code you ported but it needs to get documented anyway.

[mairaw]

LGTM but this is a new API for 3.0. In .NET Framework, this class was static, so no constructor was shown. Now in .NET Platform Extensions 3.0 for example, it was changed to sealed and so now the class has a constructor.

[mairaw]

One thing that I've noticed though is that the API catalog considers that constructor .NET Core 3.0 only, while docs is showing both:
https://apisof.net/catalog/System.Security.Cryptography.X509Certificates.X509Certificate2UI..ctor()
https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2ui.-ctor

However, I can't find that API in the assemblies I have for .NET Core 3.0, just in the .NET Platform Extension one. What should be the correct behavior so I can open the bug? System.Windows.Extensions.dll was sent to me as part of extensions, not the shared framework. /cc @safern @terrajobst

[carlossanlop]

The build failed, but the root cause was unrelated to my change. Closing and reopening to trigger a new build.

[safern]

However, I can't find that API in the assemblies I have for .NET Core 3.0, just in the .NET Platform Extension one. What should be the correct behavior so I can open the bug? System.Windows.Extensions.dll was sent to me as part of extensions, not the shared framework.

System.Windows.Extensions is not part of the shared framework, it ships as an OOB package, but I believe winforms brings it into its closure as a package reference, just as it does with System.Drawing.Common. The reason why it is showing in APICatalog is because we mixed up the the drops, but we will fix this sometime soon.

[carlossanlop]

@mairaw the build passed. Can we get this merged?

[mairaw]

@safern sounds good!

@carlossanlop yes, merging now!