Automatically port System.Text.Json.Utf8JsonWriter #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
ahsonkhan,
jozkee,
mairaw,
rpetrusha and
steveharter
carlossanlop
commented
Aug 1, 2019
rpetrusha
suggested changes
Aug 2, 2019
There was a problem hiding this comment.
I've directly modified the file to remove duplicated exceptions and make some stylistic changes, @carlossanlop. I've also suggested one additional change.
|
The build finished, @rpetrusha. Is this good to merge? |
carlossanlop
added
changes-addressed
rpetrusha
approved these changes
Aug 5, 2019
|
Yes, this is ready to merge, @carlossanlop. I'll do it now. |
mairaw
removed
the
changes-addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New batch.