Automatically port System.Text.Json.Serialization.JsonConverter #2889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
ahsonkhan,
jozkee,
mairaw,
rpetrusha and
steveharter
rpetrusha
suggested changes
Aug 1, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
@jozkee has made a number of suggestions, @carlossanlop, one of which I've edited.
Co-Authored-By: David Cantu <[email protected]>
carlossanlop
added
changes-addressed
jozkee
requested changes
Aug 1, 2019
Member
jozkee
left a comment
jozkee
left a comment
There was a problem hiding this comment.
Sorry for the typo in my previous suggestion.
Co-Authored-By: David Cantu <[email protected]>
ahsonkhan
reviewed
Aug 2, 2019
ahsonkhan
reviewed
Aug 2, 2019
Co-Authored-By: Ahson Khan <[email protected]>
Co-Authored-By: Ahson Khan <[email protected]>
Contributor
Author
|
@rpetrusha the latest suggestion has been addressed. If it looks good, can we get it merged if the build finishes successfully? |
carlossanlop
added
verify-build-before-merge
and removed
changes-addressed
Contributor
Author
|
@rpetrusha the build passed, I think this one's good to merge. |
rpetrusha
approved these changes
Aug 6, 2019
|
It is good to merge, @carlossanlop. I'll do that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New batch.