Skip to content

Automatically port System.Text.Json.JsonSerializer #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2019
Merged

Automatically port System.Text.Json.JsonSerializer #2880

merged 3 commits into from
Aug 2, 2019

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Jul 31, 2019

New batch.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Jul 31, 2019
@carlossanlop carlossanlop added this to the July 2019 milestone Jul 31, 2019
@carlossanlop carlossanlop self-assigned this Jul 31, 2019
@mairaw mairaw modified the milestones: July 2019, August 2019 Jul 31, 2019
jozkee
jozkee requested changes Jul 31, 2019
View reviewed changes
Copy link
Member

@jozkee jozkee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, I saw many issues where the exceptions were duplicated 5 times and references to parameters in the Remarks section were wrapped within an xref tag rather than just wrapping it within accents.

@rpetrusha rpetrusha removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Jul 31, 2019
rpetrusha
rpetrusha approved these changes Jul 31, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've edited the documentation and also incorporated the comments from @jozkee, @carlossanlop. Please take a look, and I'll merge when a successful build completes.

@carlossanlop
Copy link
Contributor Author

carlossanlop commented Aug 1, 2019

Thanks @rpetrusha for incorporating and completing the suggestions.

@carlossanlop
Copy link
Contributor Author

carlossanlop commented Aug 2, 2019

The build passed @rpetrusha. This looks fully baked and ready to get merged.

@mairaw mairaw merged commit 28b6457 into dotnet:master Aug 2, 2019
@carlossanlop carlossanlop deleted the JsonSerializer branch September 22, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jozkee jozkee jozkee requested changes

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@steveharter steveharter Awaiting requested review from steveharter

@mairaw mairaw Awaiting requested review from mairaw

+1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlossanlop carlossanlop

Labels

🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop @rpetrusha @jozkee @mairaw