Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 29, 2019

Fixes #2685, related to #1682

@bartonjs can you please make sure my changes are technically accurate for X509Certificate2.PrivateKey and one of its constructors?

@mairaw mairaw requested a review from bartonjs July 29, 2019 22:53
@mairaw mairaw self-assigned this Jul 29, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I've left a few suggestions.

@mairaw mairaw merged commit c78326d into master Jul 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the mairaw-patch-3 branch July 31, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remarks are not correct for .NET Core

4 participants