Skip to content

remove remarks about ref struct #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

remove remarks about ref struct #2863

merged 1 commit into from
Jul 30, 2019

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 29, 2019

Fixes #2707

@mairaw mairaw requested a review from ahsonkhan July 29, 2019 22:38
@mairaw mairaw mentioned this pull request Jul 29, 2019
Closed
@mairaw mairaw self-assigned this Jul 29, 2019
ahsonkhan
ahsonkhan approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://github.com/dotnet/corefx/blob/eb44b1ffe5f9aeb9852beee0fc123add3fe47492/src/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.cs#L18-L36, LGTM.

Thraka
Thraka approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@Thraka Thraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mairaw mairaw merged commit 5ed24c8 into master Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the mairaw-patch-2 branch July 30, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Thraka Thraka Thraka approved these changes

@ahsonkhan ahsonkhan ahsonkhan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mairaw mairaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Utf8JsonWriter: stale documentation

4 participants

@mairaw @Thraka @ahsonkhan