Document System.IO.WindowsRuntimeStorageExtensions #2846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
🏁 Release: .NET Core 3.0
Member
|
#1962 has the original request. |
JeremyKuhne
reviewed
Jul 26, 2019
JeremyKuhne
reviewed
Jul 27, 2019
carlossanlop
commented
Jul 29, 2019
carlossanlop
commented
Jul 29, 2019
carlossanlop
added
changes-addressed
rpetrusha
approved these changes
Jul 30, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I've made a few minor changes, @carlossanlop, but this looks good. It's ready to merge once @JeremyKuhne approves.
JeremyKuhne
reviewed
Jul 30, 2019
JeremyKuhne
reviewed
Jul 30, 2019
Contributor
|
Good to merge @JeremyKuhne? |
mairaw
added
waiting-on-feedback
Contributor
Author
|
@JeremyKuhne do my last changes look good to you? We would like your confirmation so we can get this PR merged. It'll only take a minute. |
JeremyKuhne
approved these changes
Aug 5, 2019
mairaw
removed
the
waiting-on-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JeremyKuhne wrote these. Can you please take a look?
API Proposal: https://github.com/dotnet/corefx/issues/18759
PR: dotnet/corefx#19029
Public information in StackOverflow by MSFT member about the new Windows interfaces: https://stackoverflow.com/questions/42799235/how-can-i-get-a-win32-handle-for-a-storagefile-or-storagefolder-in-uwp#42799236
Files:
https://github.com/dotnet/corefx/blob/master/src/System.Runtime.WindowsRuntime/src/System/IO/WindowsRuntimeStorageExtensions.cs#L179
The public API for IStorageFolderHandleAccess.Create: https://docs.microsoft.com/en-us/windows/win32/api/windowsstoragecom/nf-windowsstoragecom-istoragefolderhandleaccess-create
The public API for IStorageItemHandleAccess.Create: https://docs.microsoft.com/en-us/windows/win32/api/windowsstoragecom/nf-windowsstoragecom-istorageitemhandleaccess-create