Skip to content

Conversation

@stakx
Copy link
Contributor

@stakx stakx commented Jul 26, 2019

Summary

The Remarks section of the API reference docs for System.ComponentModel.DateTimeConverter contains a very minor inaccuracy, stating that this converter uses dddd-mm-yy as the format when formatting DateTimes for the invariant culture.

This is incorrect, the actual used format is dddd-MM-yy. (Note the capitalized MM, which stands for months, whereas lower-case mm would designate minutes.)

@rpetrusha rpetrusha added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jul 26, 2019
@rpetrusha rpetrusha added this to the July 2019 milestone Jul 26, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for contributing to the dotnet/dotnet-api-docs repo, @stakx, and for correcting this incorrect custom format string. We'll merge your PR once our internal build completes successfully.

@rpetrusha rpetrusha merged commit b2ed49e into dotnet:master Jul 28, 2019
@stakx stakx deleted the datetimeconverter-format-string-inaccuracy branch July 28, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants