Try. NET update for system.collections.generic.list-1.* #2838
Conversation
WilliamAntonRohm
changed the title
|
@BillWagner -- Bill, please review this article update alongside sample PR 1115 @mairaw -- fyi |
|
We'll start the review soon. You can ping me now since I'm back from vacation already. |
|
Reopening to see if the new sample shows up. |
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Thanks @WilliamAntonRohm. You called this PR for list-1.add but you've actually done it for list-1.capacity, which is fine but not sure if this the one you wanted to test. Also, on the spreadsheet several APIs might fall on the same xml file, so you might want to combine them in one PR.
I also left a comment on where the note should be placed.
mairaw
added
vendor-task
vendor-project
|
Indentation was slightly off on the rendered sample: Opened a new PR for that dotnet/samples#1123 You can check the results here: https://review.docs.microsoft.com/en-us/dotnet/api/system.collections.generic.list-1.capacity?view=netframework-4.8&branch=pr-en-us-2838 Can you please address my comments here @WilliamAntonRohm? |
|
@mairaw -- thank you for correcting the indentation with your new PR. Going forward, I'll be sure the indentation is correct for both snippet tags & comment output. |
|
I'll close and reopen this because the build seems stuck still. I can see the result on OPS but for some reason it's not showing up here. |
mairaw
changed the title
|
The same snippet reference "~/samples/snippets/csharp/VS_Snippets_CLR/List`1_Class/cs/source.cs#1" is used throughout this file several times. You could add the note and the -interactive to all of those at once as well since the snippet was changed if you don't mind. You can do that in the new PR you're working on. |
|
And I've changed the PR title to indicate the right API name where this is being added. |
|
I'll update those snippet reference instances & add the corresponding notes -- thanks for updating the title! |
|
On this same PR @WilliamAntonRohm or on a new one? |
|
@mairaw -- in this same PR, as they're identical changes to the original single change. If you prefer, I'll sign-off on this PR (2838) and roll them into my new combined PR instead. |
|
Updated remaining 8 instances of that sample snippet (for a total of 9). #sign-off |
WilliamAntonRohm
changed the title
|
Reviewing now... |
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Looks good @WilliamAntonRohm. One tiny correction before we merge.
Co-Authored-By: Maira Wenzel <[email protected]>
|
#sign-off |
|
Thanks @WilliamAntonRohm. Feel free to open additional PRs so you don't have to keep waiting for our reviews to move forward. |
|
Closed accidentally 🤦♀ |
|
@mairaw -- it seems you need to approve the most recent change (plural-to-singular) before this PR can be merged. Thank you. |
|
I did already. I'll just wait for build to finish again to merge this. |
|
@mairaw -- thank you for approving -- I was three minutes behind the times :^) |
|
#sign-off |
2 participants
per work item https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1558837/
related samples PR is dotnet/samples#1115
applies to:
.ctor
Add
Capacity
Clear
Count
Insert
Remove
TrimExcess