Skip to content

Add visual basic snippet code #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add visual basic snippet code #2706

wants to merge 2 commits into from

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 5, 2019 •
edited by mairaw
Loading

Related to:
dotnet/samples#1059

Fixes #2596

@Youssef1313 Youssef1313 requested a review from karelz as a code owner July 5, 2019 19:35
@Youssef1313 Youssef1313 mentioned this pull request Jul 5, 2019
Merged
@mairaw mairaw added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jul 5, 2019
@BillWagner BillWagner added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jul 8, 2019
@BillWagner
Copy link
Member

BillWagner commented Jul 8, 2019

closing and reopening to check build status.

@BillWagner BillWagner closed this Jul 8, 2019
@BillWagner BillWagner reopened this Jul 8, 2019
@BillWagner BillWagner removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jul 8, 2019
@BillWagner
Copy link
Member

BillWagner commented Jul 8, 2019

dotnet/samples#1059 has been merged. Removing the "hold" label.

@mairaw
Copy link
Contributor

mairaw commented Jul 8, 2019

I kicked off the build for the master branch to pick up the latest samples and will restart this build once that's done.

@mairaw mairaw closed this Jul 9, 2019
@mairaw mairaw reopened this Jul 9, 2019
mairaw
mairaw requested changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VB example now displays nicely in the Examples section. There's still an example in C# only in the remarks for the HttpClient class (line 61). Can you also address that @Youssef1313? Thanks!

@mairaw mairaw added this to the July 2019 milestone Jul 9, 2019
@Youssef1313
Copy link
Member Author

Youssef1313 commented Jul 9, 2019

VB example now displays nicely in the Examples section. There's still an example in C# only in the remarks for the HttpClient class (line 61). Can you also address that @Youssef1313? Thanks!

Thanks, I've added it.

mairaw
mairaw reviewed Aug 5, 2019
View reviewed changes
xml/System.Net.Http/HttpClient.xml
```
```
```vb
Copy link
Contributor

@mairaw mairaw Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same on line 61. do you want to add there as well?

@Youssef1313
Copy link
Member Author

Youssef1313 commented Aug 6, 2019

@mairaw , My forked repo was deleted and couldn't push more commits to this PR. I'll open a new one and then close this.

@Youssef1313 Youssef1313 mentioned this pull request Aug 6, 2019
Merged
@Youssef1313
Copy link
Member Author

Youssef1313 commented Aug 6, 2019

#2936

Closing this..

@Youssef1313 Youssef1313 closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw requested changes

@karelz karelz Awaiting requested review from karelz

Assignees

@Youssef1313 Youssef1313

Labels

✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository

Projects

None yet

Milestone

July 2019

Development

Successfully merging this pull request may close these issues.

Add VB version - HttpClient class

3 participants

@Youssef1313 @BillWagner @mairaw