Automatically port System.Data triple slash comments #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Adding area owners for review: @divega, @ajcvickers, @afsanehr, @David-Engel, @Gary-Zh For language review: @mairaw @rpetrusha |
mairaw
requested changes
Jul 2, 2019
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Looks good overall. Left some comments to be addressed.
Co-Authored-By: Maira Wenzel <[email protected]>
carlossanlop
added
the
waiting-on-reviews
carlossanlop
requested review from
Gary-Zh,
ajcvickers,
cheenamalhotra and
divega
divega
suggested changes
Jul 18, 2019
Contributor
Author
|
@mairaw @divega all comments have been addressed. There is only one question to @TianqiZhang that needs an answer. If there's nothing else to address, we can wait for the build to complete and then merge. |
divega
reviewed
Jul 22, 2019
mairaw
approved these changes
Jul 24, 2019
mairaw
added
verify-build-before-merge
and removed
waiting-on-reviews
Contributor
|
@divega is this good to merge? |
mairaw
added
waiting-on-feedback
divega
approved these changes
Jul 25, 2019
Contributor
|
@mairaw, @carlossanlop looks good to me. |
carlossanlop
added
verify-build-before-merge
and removed
waiting-on-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an additional batch of APIs documented in triple slash that were not documented in Docs.