Skip to content

fix exception types for span #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2019
Merged

fix exception types for span #2653

merged 1 commit into from
Jun 28, 2019

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jun 27, 2019

@mairaw mairaw added this to the June 2019 milestone Jun 27, 2019
@mairaw mairaw self-assigned this Jun 27, 2019
rpetrusha
rpetrusha approved these changes Jun 27, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. You can merge when you're ready.

@mairaw mairaw merged commit 0cfe24d into master Jun 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the mairaw-patch-2 branch June 28, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mairaw mairaw

Labels

None yet

Projects

None yet

Milestone

June 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@mairaw @rpetrusha