Skip to content

Conversation

@gewarren
Copy link
Contributor

Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=574983&view=results
source_repo.branch:master
source_repo.url:https://apidrop.visualstudio.com/_git/binaries

Copilot AI review requested due to automatic review settings October 30, 2025 20:33
@gewarren gewarren requested a review from a team as a code owner October 30, 2025 20:33
@github-actions github-actions bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Oct 30, 2025
@gewarren gewarren requested a review from BillWagner October 30, 2025 20:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates C# method signatures in XML documentation files to use ref readonly modifiers for parameters that shouldn't be modified by the method. The changes align the documentation with API signature updates across multiple framework versions (net-8.0, net-9.0, and net-10.0).

Key Changes:

  • Updated method signatures to use ref readonly for read-only reference parameters across core System types
  • Added framework-specific signatures to distinguish between older versions using ref and newer versions using ref readonly
  • Corrected XML cross-reference (altmember) ordering issues in documentation

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
xml/System/ReadOnlySpan`1.xml Updated ReadOnlySpan constructor to use ref readonly parameter
xml/System/Nullable.xml Updated GetValueRefOrDefaultRef to use ref readonly parameter
xml/System.Threading/Volatile.xml Updated all Read method overloads to use ref readonly for newer frameworks
xml/System.Threading/Interlocked.xml Updated Read methods to use ref readonly with framework-specific signatures
xml/System.Runtime.Intrinsics/*.xml Updated LoadUnsafe methods across Vector types to use ref readonly
xml/System.Runtime.InteropServices/*.xml Updated various methods to use ref readonly parameters
xml/System.Runtime.CompilerServices/Unsafe.xml Updated multiple unsafe methods to use ref readonly parameters
xml/System.Reflection/TypeExtensions.xml Restored extension method signatures and metadata
xml/System.Numerics/*.xml Updated LoadUnsafe methods in Vector types
xml/System.Formats.Asn1/*.xml Reordered altmember references for consistency
xml/Microsoft.Extensions.VectorData/VectorStore.xml Reordered altmember references
xml/Microsoft.Extensions.DependencyInjection/FromKeyedServicesAttribute.xml Reordered altmember references

@gewarren gewarren enabled auto-merge (squash) October 30, 2025 22:55
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren
When you're ready, let's :shipit:

@gewarren gewarren merged commit dcf8b71 into main Oct 31, 2025
13 checks passed
@gewarren gewarren deleted the ref-readonly branch October 31, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants